Codecov Report

Merging #2244 into python will increase coverage by <1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           python   #2244    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         377     377            
  Lines       18941   18941            
=======================================
+ Hits        13560   13580    +20     
+ Misses       5381    5361    -20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db1d71...c2639fa. Read the comment docs.

@junghans have you checked if doing the following would fix the issue?:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${MPI_CXX_COMPILE_FLAGS}")

The documentation says:

In new projects, please use the MPI__XXX equivalents

@KaiSzuttor the problem persists. If you look at my fix, the problem is actually in MPI_COMPILE_OPTIONS, which then becomes MPI_${LANG}_COMPILE_OPTIONS, which is then part of MPI_CXX_COMPILE_FLAGS.

@KaiSzuttor: You guys required cmake-3.0 which came with https://gitlab.kitware.com/cmake/cmake/blob/v3.0.0/Modules/FindMPI.cmake, so this might be a good time to switch to MPI_CXX_COMPILE_FLAGS anyhow.

thanks, @junghans Could you please switch to the new syntax since you are touching this?

@KaiSzuttor Done

thanks @junghans

Fixed in CMake: https://gitlab.kitware.com/cmake/cmake/merge_requests/2368